gitadmin/INSIGHT-MVP
1
0
Fork 0
mirror of http://172.20.10.11:3000/gitadmin/INSIGHT-MVP.git synced 2026-06-25 00:16:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: make GET /settings/branding public to break login loading loop

Browse source 
LoginPage calls /settings/branding to load branding config (logo, colors).
Without @Public(), the JWT guard returns 401, which triggered the axios
response interceptor to attempt a silent refresh, fail, and call
window.location.href = '/login' — creating an infinite reload loop on
the login page itself.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Thomas Reitz 2026-03-14 11:44:50 +01:00
parent ad3a580d0b
commit 98e7f48ce2
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/core-service/src/core/settings/settings.controller.ts
View file

@ -10,6 +10,7 @@ import {
BadRequestException, BadRequestException,
} from '@nestjs/common'; } from '@nestjs/common';
import { ApiTags, ApiOperation } from '@nestjs/swagger'; import { ApiTags, ApiOperation } from '@nestjs/swagger';
import { Public } from '../../common/decorators/public.decorator';
import { Roles } from '../../common/decorators/roles.decorator'; import { Roles } from '../../common/decorators/roles.decorator';
import { RolesGuard } from '../../common/guards/roles.guard'; import { RolesGuard } from '../../common/guards/roles.guard';
import { randomUUID, X509Certificate, createPrivateKey } from 'crypto'; import { randomUUID, X509Certificate, createPrivateKey } from 'crypto';
@ -152,6 +153,7 @@ export class SettingsController {
* Branding-Einstellungen lesen (Logo, Sidebar-Farbe, Login-Hintergrund etc.). * Branding-Einstellungen lesen (Logo, Sidebar-Farbe, Login-Hintergrund etc.).
*/ */
@Get('branding') @Get('branding')
@Public()
@ApiOperation({ summary: 'Branding-Einstellungen lesen' }) @ApiOperation({ summary: 'Branding-Einstellungen lesen' })
async getBranding(): Promise<{ async getBranding(): Promise<{
logo: string | null; logo: string | null;